Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with other 2SCM attribute preserves other attributes on click after link #7666

Closed
jodator opened this issue Jul 22, 2020 · 3 comments
Closed
Labels
package:basic-styles package:link package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Jul 22, 2020

📝 Provide detailed reproduction steps (if any)

  1. Mark text fragment as link and code
  2. Click outside link (to change selection)
  3. Click after a link (

✔️ Expected result

Probably all the attributes should be removed (you shouldn't type with anything).

❌ Actual result

The code selection attribute is active and you type with it.

Ps.: I had some trouble (as seen in the above GIF) to click just after a link. In most cases I was clicking outside both (on a space?). On another text it was after a first try.

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:basic-styles package:link package:typing labels Jul 22, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Aug 31, 2020
@Reinmar
Copy link
Member

Reinmar commented Aug 31, 2020

This is a bit more serious than it seems.

The issue here is that when we click after the link, the link feature forces the selection to be outside the link. However, it does not force it to be outside of the code. And since <code> is in <a> a new <code> is being created at the selection position.

I think that the mechanism in the link feature should be smarter and if there's no link on the right-hand side use the attributes from the right (change the gravity). However, it may be really tricky to sync this with the 2 step caret movement mechanism.

@Reinmar Reinmar removed the squad:core Issue to be handled by the Core team. label Aug 31, 2020
@Reinmar Reinmar added this to the backlog milestone Aug 31, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:basic-styles package:link package:typing resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants