Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoformat intersecting styles #7364

Closed
tomalec opened this issue Jun 3, 2020 · 3 comments
Closed

Do not autoformat intersecting styles #7364

tomalec opened this issue Jun 3, 2020 · 3 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:autoformat resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@tomalec
Copy link
Contributor

tomalec commented Jun 3, 2020

This is a followup after #1239 (comment)

📝 Provide a description of the improvement

Currently, we support autoformatting the intersecting styles in many cases.

Text in _italic and **bo_ld** - > "Text in italic and bold"

After #7346 we will no longer support it in with <code>/`, as it was found confusing and undesired. It put us in a position where.

  • The behavior is inconsistent among inline styles. Text in _italic and **bo_ld** creates interesting styles, while Text in _italic and `bo_ld` don't.
  • There is a remaining question of whether intersecting styles are confusing in general - for other styles as well.

Neither Slack, Github, nor Notion supports that.

If we are about to drop this feature, autoformatting logic could be simplified to only handle currently focused text nodes.

📃 Other details


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@tomalec tomalec added the type:improvement This issue reports a possible enhancement of an existing feature. label Jun 3, 2020
@tomalec
Copy link
Contributor Author

tomalec commented Jun 4, 2020

Note, that GitHub Writer also does not support intersecting styles. Additionally, it handles markers that starts from the beginning of a line or whitespace.

@mlewand mlewand added this to the backlog milestone Jun 29, 2020
@mlewand mlewand changed the title Do not autoformat intersecting styles. Do not autoformat intersecting styles Jun 29, 2020
@mlewand mlewand added the domain:ui/ux This issue reports a problem related to UI or UX. label Jun 29, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:red labels Jul 28, 2020
@Reinmar Reinmar removed the squad:core Issue to be handled by the Core team. label Oct 16, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 13, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:autoformat resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

6 participants