Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Fonts #6674

Closed
jasperf opened this issue Apr 26, 2020 · 4 comments
Closed

Google Fonts #6674

jasperf opened this issue Apr 26, 2020 · 4 comments
Labels
resolution:expired This issue was closed due to lack of feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).

Comments

@jasperf
Copy link

jasperf commented Apr 26, 2020

There does not seem to be any documentation on how you can integrate Google Fonts in the CKEditor 5. I do see how you can work with system fonts at https://ckeditor.com/docs/ckeditor5/latest/features/font.html / https://github.com/ckeditor/ckeditor5-font . But I do not see how you can load external fonts or custom fonts. Would be great if someone can document the basics of an implementation like that.

@jasperf jasperf added the type:docs This issue reports a task related to documentation (e.g. an idea for a guide). label Apr 26, 2020
@Mgsy
Copy link
Member

Mgsy commented Apr 27, 2020

Hi! Font plugin is based on your page styles, so to use a font of your choice, you have to load it to your page, then configure the plugin to use this font.

In the current iteration, we've made some improvements to the font plugin and introduced supportAllValues config property which will be available this week, just after the v19 release.

@Mgsy Mgsy added the pending:feedback This issue is blocked by necessary feedback. label Apr 27, 2020
@jasperf
Copy link
Author

jasperf commented Apr 27, 2020

Thanks for the quick feedback @Mgsy . Looking forward to the update for suportAllValues and we will play with using loaded Fonts from Google soon. Google Fonts that are different in each project though so have to be loaded based on input given at that time. Well, we managed that with TinyMCE 4 so should be able to with CKEditor as well.

@Mgsy
Copy link
Member

Mgsy commented May 4, 2020

Hey @jasperf, CKEditor 5 v19 is released, so please check if your issue has been solved :)

@FilipTokarski
Copy link
Member

I'm closing this due to lack of activity.

@FilipTokarski FilipTokarski added resolution:expired This issue was closed due to lack of feedback. and removed pending:feedback This issue is blocked by necessary feedback. labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Development

No branches or pull requests

3 participants