Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline widget bug in Firefox #6532

Closed
ddmm-white opened this issue Apr 2, 2020 · 7 comments
Closed

Inline widget bug in Firefox #6532

ddmm-white opened this issue Apr 2, 2020 · 7 comments
Labels
resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@ddmm-white
Copy link

Hi. There is a weird issue with plugins that use inline widget in Firefox. If I press Space bar right after or before an inline widget, the widget disappears. Also it's not possible to place the caret after an inline widget using mouse. You can only do that with Right arrow key. I've recorded some screencasts for you to see what I mean:
Firefox:
recording2

Chrome:
recording3

As you can see, in Firefox it has completely different behavior. In Chrome it works fine.
JSFiddle: https://jsfiddle.net/lastMorning/1yq09k5s
Sources of custom build with this plugin: https://github.com/ddmm-white/ckeditor5-build-classic

@ddmm-white ddmm-white added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 2, 2020
@Mgsy
Copy link
Member

Mgsy commented Apr 2, 2020

@jodator, can you take a look at it?

@ddmm-white
Copy link
Author

Hi again. Can someone help with this please? I couldn't find a fix to "spacebar after formula" glitch on my own.

@jodator
Copy link
Contributor

jodator commented Apr 14, 2020

Hi @ddmm-white  it looks like your code is missing position mapping fixing.

@jodator jodator added the pending:feedback This issue is blocked by necessary feedback. label Apr 14, 2020
@ddmm-white
Copy link
Author

I updated my build and plugin, added position mapping fix and changed container element to span. But now if I enter any text after the widget, the widget turns into plain text. Also I noticed that if I create the same element (with only text inside, without UIElement) for both editingDowncast and dataDowncast converters then it starts working. But i can't do that for my custom plugin because I need UIElement for the editingDowncast converter.

@jodator
Copy link
Contributor

jodator commented Apr 15, 2020

I need UIElement for the editingDowncast converter.

Could you explain more? To be honest the inline widget sample is currently the only use-case that we've tested. The UIElement is meant to be used as elements that are not mapped to the model content of the editor. So everything that helps in editing but is not part of the data - e.g. Widget's selector handle.

In other words, there must be some ViewElement in the view so the model <-> view mappings work properly for calculating positions, etc.

So maybe you wish to accomplish something that UIElement do similarly but without expected behavior of inline widget it is hard to tell.

@FilipTokarski
Copy link
Member

I'm closing this due to lack of activity.

@FilipTokarski FilipTokarski added resolution:expired This issue was closed due to lack of feedback. and removed pending:feedback This issue is blocked by necessary feedback. labels May 29, 2020
@evgenii-petukhov
Copy link

It seems that the issue is still valid in CkEditor v34. I'm able to reproduce it in Firefox 100.0.2. I added 3 inline images, but I was unable to place the caret between them by clicking.
mouse

However, I could place the caret between images when I navigated with arrow key on my keyboard.
keyboard

There is a workaround. If I add spaces between the images from keyboard, I can place the caret between the images with mouse.
space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants