Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking error when inserting OS emoji #6520

Closed
fredck opened this issue Mar 31, 2020 · 1 comment
Closed

Blocking error when inserting OS emoji #6520

fredck opened this issue Mar 31, 2020 · 1 comment
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@fredck
Copy link
Contributor

fredck commented Mar 31, 2020

📝 Provide detailed reproduction steps (if any)

  1. Have an empty editor (like the docs demo).
  2. Paste the following (including space at the end):
I was missing this feature on multiple occasions and had to fallback to ancient WYSIWYG knowledge of "go to n-1 character and start typing from there and press delete to remove last character". 
  1. Insert an emoji using the OS (ctrl+cmd+space on mac, win+. on windows).

✔️ Expected result

The emoji is inserted and no error is thrown.

❌ Actual result

The emoji is inserted and an error is thrown.

Following that, the editor is broken. For example "select all -> backspace" will not work.

📃 Other details

  • OS: confirmed on mac and windows.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Reinmar
Copy link
Member

Reinmar commented Apr 1, 2020

It works on master already. Fixed by @niegowski in ckeditor/ckeditor5-utils#327.

@Reinmar Reinmar closed this as completed Apr 1, 2020
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants