Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highlight background color from table cells #6425

Closed
panr opened this issue Mar 12, 2020 · 3 comments
Closed

Remove highlight background color from table cells #6425

panr opened this issue Mar 12, 2020 · 3 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table resolution:expired This issue was closed due to lack of feedback. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@panr
Copy link
Contributor

panr commented Mar 12, 2020

Provide a description of the task

This a follow-up of #6229

Right now when a table cell is focused, it has a delicate blueish highlight background color and I'm not sure about that...

Actual

image

This behaviour is mainly inherited from the widget focused element styling (about which I'm not sure either 😛).

Another (small) issue with this is that ATM when the user sets the background color of a cell, the highlight set via CSS will not work... And we have something like this:

over

Expected

IMHO there's no need to highlight focused elements inside the table.

image

We implemented the highlight background color workaround in issue #6229, but I think the best way will be to remove background changing. Our focused elements have outlines and it should be enough. But if in some scenarios we decide that outline is barely visible, we can change its width to 2px (Excel and Google Sheets have set thick outlines).

Below is example with thicker outline (where cell has set 2px black border):

image

Other examples

Here are some examples from Excel and Google Sheets (I chose spreadsheet examples because they are more complex than text editors and for example in Google Docs there is no outline inside tables at all ¯_(ツ)_/¯ ):

Excel (just solid green outline and no highlighted background for selected cell):
image

Google Sheets (thick solid blue outline and no highlighted background for selected cell as well) :
image

@panr panr added type:task This issue reports a chore (non-production change) and other types of "todos". domain:ui/ux This issue reports a problem related to UI or UX. labels Mar 12, 2020
@Reinmar Reinmar added this to the backlog milestone Mar 24, 2020
@panr
Copy link
Contributor Author

panr commented Apr 16, 2020

#6446 (comment)

@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 12, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table resolution:expired This issue was closed due to lack of feedback. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants