Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests on other browsers than Chrome #5429

Closed
17 tasks done
pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#349
Closed
17 tasks done

Fix broken tests on other browsers than Chrome #5429

pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#349
Assignees
@pomek
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2017

The main issue: #615

Broken tests in this package:

  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar should fire internal _selectionChangeDebounced event 200 ms after last selection change FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should add #toolbarView to the #_balloon and attach the #_balloon to the selection for the forward selection FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should ignore the zero-width orphan rect if there another one preceding it for the forward selection FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should add #toolbarView to the #_balloon and attach the #_balloon to the selection for the backward selection FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should update balloon position on ViewDocument#render event while balloon is added to the #_balloon FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should not add #toolbarView to the #_balloon more than once FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should not add #toolbarView to the #_balloon when all components inside #toolbarView are disabled FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() should add #toolbarView to the #_balloon when at least one component inside does not have #isEnabled interface FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() on #_selectionChangeDebounced event should not be called when the editor is not focused FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() on #_selectionChangeDebounced event should not be called when the selection is collapsed FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show() on #_selectionChangeDebounced event should be called when the selection is not collapsed and editor is focused FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar hide() should remove #toolbarView from the #_balloon FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar hide() should stop update balloon position on ViewDocument#render event FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar showing and hiding "before each" hook for "should open when selection stops changing" FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show event should not show the panel when show event is stopped FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) ContextualToolbar show event should not show the panel when show event is stopped FAILED
  • Edge 16.16299.0 (Windows 10 0.0.0) Template revert() attributes style should remove bindings FAILED

In order to reproduce these issues, please follow this instruction – #615 (comment) – How to run it on my local machine?
szymonkups referenced this issue in ckeditor/ckeditor5-ui Dec 5, 2017
@szymonkups
Merge pull request #349 from ckeditor/t/334
f29fbe1 
Tests: Fixed failed tests on other browsers than Chrome when using BrowserStack. Closes #334.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

T/334: Fixed tests in order to run on BS ckeditor/ckeditor5-ui
3 participants
@pomek @szymonkups @mlewand