-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider changing image upload placeholder #5150
Comments
I've made research and there is no perfect solution to change current placeholder. I was thinking about two possibilities: 1. Inline SVG animation It is so simple and perfect solution to display inline SVG animations (SMIL), but sadly there is no Edge support 😠 2. CSS Animation That was also a solution, but in our case where 3. New element inside I don't know if it is ok to create new element inside figure while uploading. ProposalLet's use animated SVG and create nice-looking first frame of loader (which will be displayed as static on Edge). Note: placeholder has grey background, it's about screencast quality and it's not final proposal, we just need to decide about loader. Every browser (Chrome, Safari, FF)...and Edge 😢QuestionIf we'll decide to go with animated, centered loader, should we remove infinite progress bar for the user? |
I think that would be the easiest way because it allows CSS animations to create some beautiful placeholders. What about the engine side, though? cc @scofalik |
We already do it to show upload progress bar or upload complete icon. ez. |
So, you can find here proposals of loaders based on single By the way, exists a lot of beautiful CSS-only loaders, but based on plenty of spans, I'm not so sure about performance in that case. WDYT guys, should we go with default "spinner" or choose something modern like moving balls? |
Feature: Implemented a CSS–styled image upload loader. Closes #207.
Feature: Implemented a CSS–styled image upload loader (see ckeditor/ckeditor5-image#207).
At this moment we are using svg as placeholder with plain text
Uploading image...
and progress bar animation. The problem is there is no way to translate this text, because it's hardcoded in thesvg
file.We should think about something like centered spinner instead of plain text.
cc @oleq @Reinmar
The text was updated successfully, but these errors were encountered: