Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests on other browsers than Chrome #5126

Closed
4 tasks done
pomek opened this issue Oct 31, 2017 · 6 comments · Fixed by ckeditor/ckeditor5-image#161
Closed
4 tasks done

Fix broken tests on other browsers than Chrome #5126

pomek opened this issue Oct 31, 2017 · 6 comments · Fixed by ckeditor/ckeditor5-image#161
Assignees
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2017

The main issue: #615

Broken tests in this package:

  • Firefox 56.0.0 (Mac OS X 10.10.0) Image integration with the ContextualToolbar should prevent the ContextualToolbar from being displayed when an image is selected FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) ImageEngine conversion in data pipeline model to view should convert srcset attribute to width, srcset and add sizes attribute FAILED
  • Edge 16.16299.0 (Windows 10 0.0.0) ImageEngine conversion in data pipeline model to view should convert srcset attribute to srcset and sizes attribute FAILED
  • Edge 16.16299.0 (Windows 10 0.0.0) ImageEngine conversion in data pipeline model to view should convert srcset attribute to width, srcset and add sizes attribute FAILED

In order to reproduce these issues, please follow this instruction – #615 (comment)How to run it on my local machine?

@pomek
Copy link
Member Author

pomek commented Nov 7, 2017

A few tests fail on Edge because of: TypeError: Object doesn't support property or method 'Symbol.iterator'.

image

@pomek
Copy link
Member Author

pomek commented Nov 8, 2017

Firefox fails because of window/tab focus. It can be reproduced on dev machine. If you focus the tab with tests, a scenario will pass. If the focus is somewhere else, the scenario will fail.

@pomek
Copy link
Member Author

pomek commented Nov 8, 2017

A few tests fail on Edge because of: TypeError: Object doesn't support property or method 'Symbol.iterator'.

It can be related to engine/view which does not pass on Edge as well.

@oleq
Copy link
Member

oleq commented Nov 10, 2017

A few tests fail on Edge because of: TypeError: Object doesn't support property or method 'Symbol.iterator'.

ckeditor/ckeditor5-ui#338 should fix that.

@oleq
Copy link
Member

oleq commented Nov 10, 2017

Please also take a look at broken Template.revert test in Edge. It requires improvements in the normalizeHtml test util.

@pomek
Copy link
Member Author

pomek commented Nov 10, 2017

After https://github.com/ckeditor/ckeditor5-ui/issues/337 Edge works fine. Thanks.

@pomek pomek self-assigned this Nov 15, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-image Dec 5, 2017
Tests: Fixed failed tests on other browsers than Chrome when using BrowserStack. Closes #153.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants