Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DOM utils to help implementing the viewport scrolling helper #4966

Closed
oleq opened this issue Jul 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#174
Closed

Create DOM utils to help implementing the viewport scrolling helper #4966

oleq opened this issue Jul 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#174
Assignees
@oleq
Labels
package:utils type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jul 28, 2017

The viewport/ancestors scrolling helper will require certain enhancements to the Rect class and possibly other helpers.

A follow–up of https://github.com/ckeditor/ckeditor5-engine/issues/660.
@oleq oleq self-assigned this Jul 28, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-utils Aug 15, 2017
@Reinmar
Merge pull request #174 from ckeditor/t/173
b143e9c 
Feature: Created various DOM utilities to allow the view document scroll to the selection. Closes #173.

BREAKING CHANGE: The static `Rect.getViewportRect()` method has been removed. Use `new Rect( window )` instead.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
2 participants
@oleq @mlewand