Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'nth()' function tests and documentation #4943

Closed
ma2ciek opened this issue Mar 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-utils#138
Closed

Improve 'nth()' function tests and documentation #4943

ma2ciek opened this issue Mar 15, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-utils#138
Assignees
@ma2ciek
Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 9

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 15, 2017

As mentioned ckeditor/ckeditor5-utils#136 and #4938 there're some edge cases which are not tested and documented. Especially differences between taking iterators and generators as the second argument
@ma2ciek ma2ciek self-assigned this Mar 15, 2017
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Mar 16, 2017

I changed the naming a little bit according to the https://developer.mozilla.org/pl/docs/Web/JavaScript/Reference/Global_Objects/Generator definition.

Reinmar referenced this issue in ckeditor/ckeditor5-utils Mar 21, 2017
@Reinmar
Merge pull request #138 from ckeditor/t/137
d4f016d 
Internal: Added tests and docs for the edge cases in the `nth()` function. Closes #137.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:utils labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:utils type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

Added tests and docs to the edge cases in the 'nth' function. ckeditor/ckeditor5-utils
2 participants
@ma2ciek @mlewand