Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep inline filler also for non-collapsed selection in an active node #4352

Closed
f1ames opened this issue Jun 1, 2018 · 3 comments
Closed
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@f1ames
Copy link
Contributor

f1ames commented Jun 1, 2018

Extracted from ckeditor/ckeditor5-engine#1355 (comment):

Perhaps it's enough to keep the current behaviour (keeping the filler as long as the selection stays in the same text node) + extending this behaviour to non empty selection + extending jumpOverInlineFiller() for these scenarios...

Inline filler is not removed from the active node (the one in which selection is) until selection is moved. It mainly prevents breaking composition. However, it is possible to extend selection during composition which causes inline filler to be removed breaking the composition sometimes.

We would like to have the same behaviour for collapsed and non-collapsed selection, so that inline filler is not removed as long as selection (or its' beginning or end) is inside active node. Also it will require adjusting jumpOverInlineFiller() for non-collapsed selection.

@f1ames
Copy link
Contributor Author

f1ames commented Jun 1, 2018

One related issue is #4346.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added module:view type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@Reinmar Reinmar added the domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). label Nov 4, 2021
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

5 participants