Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests when using BrowserStack #4205

Closed
pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1199
Closed

Fix broken tests when using BrowserStack #4205

pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1199
Assignees
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2017

The main issue: #615

In order to reproduce issues listed below, please follow this instruction – #615 (comment)How to run it on my local machine?

Broken tests in this package.
  • Edge 16.16299.0 (Windows 10 0.0.0) EditingController conversion should convert selection from view to model FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) MutationObserver should fire mutations event with view selection instance, if dom selection can be mapped to view FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) MutationObserver should fire mutations event with viewSelection param set to null, if dom selection cannot be mapped to view FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should fire selectionChange when it is the only change FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should add only one listener to one document FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should not fire selectionChange on render FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should not fired if observer is disabled FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should not fired if there is no focus FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver should fired if there is no focus but document is read-only FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver "before each" hook FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) SelectionObserver "after each" hook for "should be true if range start and range end are in same parent" FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) "after each" hook for "should be false if range start and range end are in different parents" FAILED
  • Chrome 62.0.3202 (Mac OS X 10.9.5) Renderer render similar selection should not render non-collapsed selection it is similar (element start) FAILED
  • Chrome 62.0.3202 (Mac OS X 10.9.5) Renderer render similar selection should not render non-collapsed selection it is similar (element end) FAILED
  • Chrome 62.0.3202 (Mac OS X 10.9.5) Renderer render similar selection should not render non-collapsed selection it is similar (element start - nested) FAILED
  • Chrome 62.0.3202 (Mac OS X 10.9.5) Renderer render similar selection should not render non-collapsed selection it is similar (element end - nested) FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection do nothing when another key is pressed FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui element when right arrow is pressed before ui element - directly before ui element FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui element when right arrow is pressed before ui element - not directly before ui element FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over multiple ui elements when right arrow is pressed before ui element FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui elements at the end of container element FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui element if selection is in attribute element - case 1 FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui element if selection is in attribute element - case 2 FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over ui element if selection is in multiple attribute elements FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over empty attribute elements and ui elements FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler collapsed selection jump over empty attribute elements and ui elements if shift key is pressed FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler non-collapsed selection jump over ui element if shift key is pressed FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler non-collapsed selection jump over ui element if selection is in multiple attribute elements FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Document jump over ui element handler non-collapsed selection jump over empty attribute elements and ui elements if shift key is pressed FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) DomConverter isDomSelectionCorrect() should return false if anchor or focus is directly inside dom element that represents view ui element FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) DomConverter isDomSelectionCorrect() should return false if anchor or focus is inside deep ui element structure (not directly in ui element) FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) SelectionObserver should re-render view if selections are similar if DOM selection is in incorrect place FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Renderer render should not change selection if there is no editable with selection FAILED
  • Safari 11.0.0 (Mac OS X 10.13.0) Renderer render should not change selection if there is no focus FAILED
  • ...and more. I was not able to track all failed tests.
szymonkups referenced this issue in ckeditor/ckeditor5-engine Dec 5, 2017
Tests: Fixed failed tests on other browsers than Chrome when using BrowserStack. Closes #1177.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants