Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disappearing cell selection border #3183

Closed
oleq opened this issue Jun 4, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-theme-lark#181 or ckeditor/ckeditor5-theme-lark#176
Closed

Disappearing cell selection border #3183

oleq opened this issue Jun 4, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-theme-lark#181 or ckeditor/ckeditor5-theme-lark#176
Assignees
@jodator
Labels
package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Jun 4, 2018

A followup of ckeditor/ckeditor5-table#23 (comment).

image

image
@oleq oleq changed the title Missing cell selection border Disapprearing cell selection border Jun 4, 2018
@oleq oleq changed the title Disapprearing cell selection border Disappearing cell selection border Jun 4, 2018
@oleq
Copy link
Member Author

oleq commented Jun 4, 2018

Possible solution ckeditor/ckeditor5-table#23 (comment).

dkonopka referenced this issue in ckeditor/ckeditor5-theme-lark Jun 13, 2018
@dkonopka
Merge pull request #176 from ckeditor/t/ckeditor5-table/2
1cfd2a6 
Internal: Moved table editing styles from ckeditor5-table. Decreased the specificity of the widget's nested editable styles to make it possible to style tables as a content (see ckeditor/ckeditor5-table#2). Partially fixes ckeditor/ckeditor5-table#29.
@jodator
Copy link
Contributor

jodator commented Jun 19, 2018

I still can reproduce this issue: ckeditor/ckeditor5-table#69:

When there are colspans/rowspans in cells the border-based selection is messed up:

selection_041

I've found that the box-shadow: inset plays well:

selection_042

I've used this:

.ck-widget.table {
	& td,
	& th {
		&.ck-editor__nested-editable.ck-editor__nested-editable_focused {
			border-style: none;
			box-shadow: var(--ck-inner-shadow), 0 0, inset 0px 0px 0 1px var(--ck-color-focus-border);
		}
	}
}

@jodator jodator reopened this Jun 19, 2018
@jodator jodator self-assigned this Jun 21, 2018
@Reinmar
Copy link
Member

Reinmar commented Jun 26, 2018

How's this ticket different from https://github.com/ckeditor/ckeditor5-table/issues/69? Shouldn't this one be closed as a DUP?

@jodator
Copy link
Contributor

jodator commented Jun 26, 2018

@Reinmar I've reopen this by mistake and forgot about it. Let's keep this closed and use ckeditor/ckeditor5-table#69 only.

@Reinmar Reinmar closed this as completed Jun 26, 2018
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jun 29, 2018
@oleq
Merge pull request #181 from ckeditor/t/ckeditor5-table/69
084e9bb 
Fix: The table cell selection highlight is broken around merged cells. Closes ckeditor/ckeditor5-table#69. Closes ckeditor/ckeditor5-table#29.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added resolution:duplicate This issue is a duplicate of another issue and was merged into it. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
4 participants
@Reinmar @jodator @oleq @mlewand