Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar positioning and collision issues #3180

Closed
oleq opened this issue Jun 4, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#33
Closed

Toolbar positioning and collision issues #3180

oleq opened this issue Jun 4, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#33
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@oleq
Copy link
Member

oleq commented Jun 4, 2018

There are 2 serious issues regarding the table toolbar:

Collision with the balloon editor

image

Effectively there's no way for format the content in the table when using the balloon toolbar.

Wrong position when using other tools

Other features using the ContextualBalloon should not use the position of the table toolbar (the link balloon should be attached to the link in the cell).

image

A follow-up of
@oleq
Copy link
Member Author

oleq commented Jun 4, 2018

This issue could boil down to #852, which a bad news because it means a big refactoring in the contextual balloon.

@oleq oleq changed the title Toolbar positioning issues and collision Toolbar positioning and collision issues Jun 4, 2018
oleq referenced this issue in ckeditor/ckeditor5-ui Jun 7, 2018
@oleq
Other: Made the ContextualBalloon always use the position of the topm…
eda46b4 
…ost view in the stack (see: ckeditor/ckeditor5-table#28).
jodator referenced this issue in ckeditor/ckeditor5-ui Jun 8, 2018
@jodator
Merge pull request #406 from ckeditor/t/ckeditor5-table/28
a2ef073 
Other: Made the `ContextualBalloon` always use the position of the topmost view in the stack (see: ckeditor/ckeditor5-table#28). Closes ckeditor/ckeditor5#900.
jodator referenced this issue in ckeditor/ckeditor5-table Jun 8, 2018
@jodator
Merge pull request #33 from ckeditor/t/28
037df98 
Fix: The `BalloonToolbar` should be enabled for a table content. Link editing should be possible in the table. Closes #28.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 9, 2019
Closed
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
Development

Successfully merging a pull request may close this issue.

t/28: The BalloonToolbar should be enabled for a table content ckeditor/ckeditor5-table
2 participants
@oleq @mlewand