Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests on other browsers than Chrome #2926

Closed
2 tasks done
pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-core#106
Closed
2 tasks done

Fix broken tests on other browsers than Chrome #2926

pomek opened this issue Oct 31, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-core#106
Assignees
@pomek
Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 13

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2017

The main issue: #615

Broken tests in this package:

  • Safari 11.0.0 (Mac OS X 10.13.0) StandardEditor attaching to a form should not replace submit() method when one of the elements in a form is named "submit" FAILED
  • Firefox 56.0.0 (Mac OS X 10.10.0) StandardEditor attaching to a form should not replace submit() method when one of the elements in a form is named "submit" FAILED

In order to reproduce these issues, please follow this instruction – #615 (comment) – How to run it on my local machine?
szymonkups referenced this issue in ckeditor/ckeditor5-core Nov 2, 2017
@szymonkups
Merge pull request #106 from ckeditor/t/105
42cddc0 
Tests: Fixed failing test in Safari and Firefox. Closes #105.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:core labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 13
Development

Successfully merging a pull request may close this issue.

Fixed broken tests (BrowserStack) ckeditor/ckeditor5-core
2 participants
@pomek @mlewand