Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto embed] Selected content is removed but media is placed elsewhere when embeddable link pasted #2764

Closed
f1ames opened this issue Oct 3, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-media-embed#68
Closed

[Auto embed] Selected content is removed but media is placed elsewhere when embeddable link pasted #2764

f1ames opened this issue Oct 3, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-media-embed#68
Assignees
@jodator
Labels
package:media-embed type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 3, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

11.0.1

📋 Steps to reproduce

  1. Go to e.g. https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds/classic-editor.html.
  2. Select some text inside paragraph.
  3. Paste embeddable link (e.g. YouTube).

ae 1

✅ Expected result

Not sure TBH. If media will be placed before entire block, selected content should not be removed. Or media should just split block and be inserted on the selection position, replacing selected content.

❎ Actual result

Selected content is removed and media is placed before entire block content.

📃 Other details that might be useful

Tested on Firefox.
@Reinmar
Copy link
Member

Reinmar commented Oct 3, 2018

Strongly related to https://github.com/ckeditor/ckeditor5-media-embed/issues/36.

@Reinmar
Copy link
Member

Reinmar commented Oct 3, 2018

As I commented in #2757, IMO, autoembedding should work in place.

@jodator jodator self-assigned this Dec 12, 2018
oleq referenced this issue in ckeditor/ckeditor5-media-embed Jan 4, 2019
@oleq
Merge pull request #68 from ckeditor/t/36
5f79878 
Fix: The `AutoMediaEmbed` feature should insert media in place of a pasted link. Closes #36. Closes #49.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:media-embed labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:media-embed type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

Make auto-embed insert media in-place of pasted link. ckeditor/ckeditor5-media-embed
4 participants
@Reinmar @jodator @f1ames @mlewand