Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeCommand is only as Type exported #17105

Closed
ultraxf opened this issue Sep 16, 2024 · 3 comments · Fixed by #17126
Closed

AttributeCommand is only as Type exported #17105

ultraxf opened this issue Sep 16, 2024 · 3 comments · Fixed by #17126
Assignees
@Mati365
Labels
domain:framework-dx This issue reports a problem with the developer experience while working with the framework. package:basic-styles squad:core Issue to be handled by the Core team. type:question This issue asks a question (how to...).
Milestone
iteration 78 (v43...

Comments

@ultraxf
Copy link

ultraxf commented Sep 16, 2024

📝 Ask a question

Hi, we are currently customizing in ckeditor5 and we want to use AttributeCommand in our own plugin. We noticed, there is not possible to use a AttributeCommand, because this is only exported as Type.

Is there any reason for that? Can you provide this as normal export?
Or is there another way to do the trick?

Thx :)
@ultraxf ultraxf added the type:question This issue asks a question (how to...). label Sep 16, 2024
@Witoso
Copy link
Member

Witoso commented Sep 19, 2024

Hey! Yes, it was overlooked in the Typescript migration, we will export it in the next release.

@Witoso Witoso added squad:core Issue to be handled by the Core team. domain:framework-dx This issue reports a problem with the developer experience while working with the framework. package:basic-styles labels Sep 19, 2024
@ultraxf
Copy link
Author

ultraxf commented Sep 19, 2024

Thx for the reply :)

@ultraxf ultraxf closed this as completed Sep 19, 2024
@Witoso Witoso reopened this Sep 19, 2024
@Witoso
Copy link
Member

Witoso commented Sep 19, 2024

Let's keep it open, we will close when it's added.

@Mati365 Mati365 self-assigned this Sep 19, 2024
@Mati365 Mati365 mentioned this issue Sep 19, 2024
Merged
@CKEditorBot CKEditorBot added this to the iteration 78 milestone Sep 19, 2024
@CKEditorBot CKEditorBot mentioned this issue Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:framework-dx This issue reports a problem with the developer experience while working with the framework. package:basic-styles squad:core Issue to be handled by the Core team. type:question This issue asks a question (how to...).
Projects
None yet
Milestone
iteration 78 (v43.2.0)
Development

Successfully merging a pull request may close this issue.

Export AttributeCommand class from basic styles package ckeditor/ckeditor5
4 participants
@Mati365 @Witoso @CKEditorBot @ultraxf