Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image contextual toolbar does not disappear after clicking source editing. #16739

Closed
blucayzer opened this issue Jul 17, 2024 · 4 comments · Fixed by #16750
Closed

Image contextual toolbar does not disappear after clicking source editing. #16739

blucayzer opened this issue Jul 17, 2024 · 4 comments · Fixed by #16750
Assignees
Labels
package:image package:source-editing type:bug This issue reports a buggy (incorrect) behavior.

Comments

@blucayzer
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Have a CKEditor 5 Classic Editor.
  2. Insert an image via URL
  3. Click SourceEditing.

This bug can be replicated if the first HTML tag is a figure. If the first HTML tag isn't a figure, the image contextual toolbar will disappear.

✔️ Expected result

image

The Image contextual toolbar should disappear after clicking the Source Editing.

❌ Actual result

image

The Image contextual toolbar does not disappear after clicking the Source Editing.

📃 Other details

  • Browser: Edge
  • CKEditor Version: v39
  • This bug can be seen in the latest version of CKEditor.
  • Can be replicated in the CKEditor Builder as seen in the screenshot above
  • Installed CKEditor plugins: Source Editing and Image

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@blucayzer blucayzer added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 17, 2024
@Witoso
Copy link
Member

Witoso commented Jul 17, 2024

Thanks for the report! Not reproducible in the docs, reproducible in the Builder and output (checked stackblitz).

@Witoso
Copy link
Member

Witoso commented Jul 17, 2024

@blucayzer do I understand correctly you reproduce it in v39?

@blucayzer
Copy link
Author

blucayzer commented Jul 17, 2024

@Witoso, yes. I migrated my CKEditor from v33 to v39 and noticed this change.

@Mati365 Mati365 self-assigned this Jul 17, 2024
@Mati365
Copy link
Member

Mati365 commented Jul 17, 2024

I was able to reproduce this issue using the table toolbar, so it appears to be a global problem. It’s essential to ensure that the element with the toolbar is the first one in the document.

obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image package:source-editing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants