Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu bar items are truncated on Firefox #16151

Closed
Mati365 opened this issue Apr 3, 2024 · 6 comments
Closed

Menu bar items are truncated on Firefox #16151

Mati365 opened this issue Apr 3, 2024 · 6 comments
Labels
browser:firefox package:ui resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mati365
Copy link
Member

Mati365 commented Apr 3, 2024 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open http://localhost:8125/ckeditor5-ui/tests/manual/menubar/menubar.html
  2. Menu is truncated

obraz

✔️ Expected result

Menu bar items are not truncated on Firefox

❌ Actual result

Menu bar items are truncated on Firefox

❓ Possible solution

Incorrect flex and baseline CSS properties on menu buttons. Setting bigger line-height (e.g.: line-height: normal;) fixes issue.

📃 Other details

  1. The issue does not happen in incognito mode.
  2. Possible font rendering issue on Linux (it happens quite often).
  3. Can be reproduced using LiveCD Fedora 39 XFCE.
  • Browser: Firefox 124.0.1
  • OS: Linux / Fedora 39 XFCE

obraz
obraz
@Mati365 Mati365 added type:bug This issue reports a buggy (incorrect) behavior. package:ui release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Apr 3, 2024
@Mati365 Mati365 mentioned this issue Apr 3, 2024
Closed
@Mati365 Mati365 added browser:firefox squad:collaboration Issue to be handled by the Collaboration team. labels Apr 4, 2024
@Mati365 Mati365 mentioned this issue Apr 4, 2024
Open
@pomek pomek removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Apr 4, 2024
@scofalik
Copy link
Contributor

scofalik commented Apr 4, 2024

May be related https://bugzilla.mozilla.org/show_bug.cgi?id=1541964

@oleq
Copy link
Member

oleq commented Nov 7, 2024

@Mati365 Could you confirm whether this was fixed by #17423?

@Mati365
Copy link
Member Author

Mati365 commented Nov 12, 2024

@oleq While, overflow issue has been fixed, the new regression has been introduced. Vertical align of menu items is incorrect on Firefox, and titles are not centered properly in the menu bar list.

Image

@oleq
Copy link
Member

oleq commented Nov 18, 2024

I couldn't reproduce it in FF on Mac or Windows.

@oleq
Copy link
Member

oleq commented Nov 18, 2024

I couldn't reproduce it in Ubuntu either

Image

@Mati365 Mati365 closed this as completed Nov 18, 2024
@Mati365
Copy link
Member Author

Mati365 commented Nov 18, 2024

It may be related to my local setup. Closing for now

@DawidKossowski DawidKossowski added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:firefox package:ui resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix truncated menu bar rendering on Firefox/Linux ckeditor/ckeditor5
5 participants
@oleq @scofalik @pomek @Mati365 @DawidKossowski