Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor 5 + Grammar and Spelling checker by Ginger - all text in the editor is deleted #15219

Open
igrebenjuktmp opened this issue Oct 23, 2023 · 10 comments
Labels
status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@igrebenjuktmp
Copy link

igrebenjuktmp commented Oct 23, 2023

Unstable behaviour while using the Grammar and Spelling checker by Ginger extension in the Chrome browser.

If you select some text and then deselect it, then all text in the editor is deleted.
You can check it in demo:

  • e.g. select "Appreciation of diversity" text and then deselect it and after that all text content in the editor will be deleted.

Browser: Google Chrome. Version 118.0.5993.89 (Official Build) (64-bit)
OS: Windows 10

@igrebenjuktmp igrebenjuktmp added the type:bug This issue reports a buggy (incorrect) behavior. label Oct 23, 2023
@Witoso
Copy link
Member

Witoso commented Oct 23, 2023

Could you record and share a video? I cannot reproduce it.

@Witoso Witoso added the pending:feedback This issue is blocked by necessary feedback. label Oct 23, 2023
@igrebenjuktmp igrebenjuktmp changed the title CKEditor 5 + Grammarly - all text in the editor is deleted CKEditor 5 + Grammar and Spelling checker by Ginger - all text in the editor is deleted Oct 23, 2023
@igrebenjuktmp
Copy link
Author

igrebenjuktmp commented Oct 23, 2023

I made a mistake with the name of the extension, the problem is with Grammar and Spelling checker by Ginger
Here's a video https://www.vidline.com/share/V02WH2OLY2/11915835f85d995d28dbc97171bf47ee

Note that CKEditor 4 works fine with this extension

@Witoso
Copy link
Member

Witoso commented Oct 27, 2023

It would be great to report this to Ginger as well. It's highly probable they need to change the implementation on their side to handle properly the events of CKEditor 5.

@igrebenjuktmp
Copy link
Author

Could you please clarify what is the issue with the Ginger extension might be. Or maybe you have any suggestions for Ginger in this case.
I'm wondering what could change in CKEditor5, considering that CKEditor4 works fine with this extension.

@Witoso
Copy link
Member

Witoso commented Oct 30, 2023

CKEditor 5 is an entirely different editor than CKE4, written from scratch, with a new data model layer and engine. Our typing is based on the beforeInput event, and this may be the root of the issue.

I strongly believe it is up to the integration and extension to ensure it works correctly, then for us to provide some workarounds. Unless, of course, some issue is, in fact, on our side.

@igrebenjuktmp
Copy link
Author

Are there any possible workarounds in this case similar to the Grammarly extension issues (e.g. extension may be blocked)?

@Witoso
Copy link
Member

Witoso commented Oct 31, 2023

The issue you're linking is pretty dated. Grammarly worked on their side to make sure their extension works well with the CKEditor 5. I'm not sure if we will have time right now to block Ginger. If you would rather not report the issue to them, then I can do this, just let me know.

@igrebenjuktmp
Copy link
Author

Thanks for the support, I'll report the problem to Ginger and let you know if there are any updates

@igrebenjuktmp
Copy link
Author

Unfortunately there is still no feedback from Ginger. Maybe you can find out something from them about this issue

@CKEditorBot CKEditorBot removed the pending:feedback This issue is blocked by necessary feedback. label Feb 6, 2024
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants