Style dropdown: styles definitions without classes property (renaming elements)

[Kocal]

📝 Provide detailed reproduction steps (if any)

1. Add a custom style without the classes property:

// ... 
style: {
  definitions: [
    { name: 'title (h2)', element: 'h2' },
  ]
}
// ...

2. Try to open the styles dropdown:

3. See the following error:

✔️ Expected result

What is the expected result of the above steps?

The styles dropdown should be visible.

❌ Actual result

What is the actual result of the above steps?

The styles dropdown is not visible, due to the missing classes property.

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

It should be possible to define styles without specifying classes property, if the style does not need CSS classes.

If classes is really required, we should have a proper error message telling us that classes property is missing (which will be more useful than Cannot read properties from undefined (reading 'value')

📃 Other details

• Browser: …
• OS: …
• First affected CKEditor version: 39.0.2
• Installed CKEditor plugins: …

---

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

[Witoso]

Hi, changing to a feature improvement. Style dropdown was thought as a feature to add classes, not rename elements. For the example that you shared, the heading customization option looks like an ideal solution.

[Witoso]

Related: [Style] Style dropdown should insert (some) elements. #14372

[Kocal]

Hello, well I'm sorry, I think this is kind of my fault, now that I migrated our custom-editor source code to TypeScript (I was using JSDoc before), my IDE/tsc shows me an error if I remove the classes property:

I could also have seen it in the API documentation of StyleDefiniton, but this is a bit less friendly than a sentence "The following properties are required to create a new StyleDefiniton (...)` in the Feature Style documentation.

Indeed, we will use headings for my h2 example, it's just we are migrating from CKEditor 4 to 5 and I wanted to change a few things as possible.

Thanks!

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).