Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android/IME] Add tests for the current PoC #12454

Closed
Reinmar opened this issue Sep 12, 2022 · 3 comments
Closed

[Android/IME] Add tests for the current PoC #12454

Reinmar opened this issue Sep 12, 2022 · 3 comments
Assignees
@niegowski
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 58 (v35...

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 12, 2022

In #12058 we created a PoC without tests so far.

The PoC turned out to work really well, so in order to stabilize and merge it to the main IME branch, we need to add tests coverage.
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. labels Sep 12, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 12, 2022
@Reinmar
Copy link
Member Author

Reinmar commented Sep 12, 2022

One thing that we found while pre-reviewing the PoC in #12446 is what are those changes:

https://github.com/ckeditor/ckeditor5/pull/12446/files#diff-8e0d7c69269756056f12fa2ffff70ee41cd4037b6725fd1e4af279c84ac8686dR41

They seem to be only partially related to Android, but were added in this PoC. We need to at least understand why they were made.

@Reinmar
Copy link
Member Author

Reinmar commented Sep 12, 2022

IMPORTANT: Let's not try to fix new cases that we'll discover when working on this PR. Extract them and target separately.

@niegowski niegowski self-assigned this Sep 19, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 19, 2022
@niegowski
Copy link
Contributor

Closing as part of #12058.

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 28, 2022
@CKEditorBot CKEditorBot added this to the upcoming milestone Sep 28, 2022
@Reinmar Reinmar modified the milestones: upcoming, iteration 58 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 58 (v35.3.0)
Development

No branches or pull requests
3 participants
@Reinmar @niegowski @CKEditorBot