Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android/IME] Enter after the word in the middle of the heading paragraph causes an error in the console and the word disappears in GBoard #12391

Closed
dufipl opened this issue Sep 1, 2022 · 3 comments
Labels
browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dufipl
Copy link
Contributor

dufipl commented Sep 1, 2022

📝 Provide detailed reproduction steps (if any)

  1. Go to the all features manual test.
  2. Try to enter a new line using the English GBoard keyboard after the end of some Heading 1 paragraph

✔️ Expected result

Enter possible

❌ Actual result

Enter works but deletes text and causes an error:

enter disapper ime

Uncaught DOMException: Failed to execute 'collapse' on 'Selection': The offset 6 is larger than the node's length (5).
    at Renderer._updateDomSelection (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:22407:22)
    at Renderer._updateSelection (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:22353:18)
    at Renderer.render (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:21900:14)
    at Renderer.<anonymous> (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:21737:22)
    at Renderer.fire (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:1526:47)
    at Renderer.set [as isComposing] (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:827:30)
    at updateBoundObservableProperty (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:1320:34)
    at http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:1346:25
    at Set.forEach (<anonymous>)
    at Mixin.<anonymous> (http://192.168.0.137:8125/ckeditor5/tests/manual/all-features.js:1345:30)

📃 Other details

Branch: ck/11438-beforeinput-ime-research-vol1.1-android
Language: English
Keyboards: Tested on GBoard
Device: Pixel C emulator@Android v13 (API 33)


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dufipl dufipl added type:bug This issue reports a buggy (incorrect) behavior. browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. labels Sep 1, 2022
@dufipl
Copy link
Contributor Author

dufipl commented Sep 1, 2022

When enter is pressed in the middle of the word after some words have already disappeared, they show up again as nothing happened:
enter mid word ime

@dufipl dufipl changed the title [IME]Enter after the word in the middle of the heading paragraph causes an error in the console and the word disappears [IME]Enter after the word in the middle of the heading paragraph causes an error in the console and the word disappears in GBoard Sep 1, 2022
@Reinmar Reinmar changed the title [IME]Enter after the word in the middle of the heading paragraph causes an error in the console and the word disappears in GBoard [Android/IME] Enter after the word in the middle of the heading paragraph causes an error in the console and the word disappears in GBoard Sep 7, 2022
@Reinmar
Copy link
Member

Reinmar commented Sep 7, 2022

This issue may be related to #12368 (and the rest of the Enter problems).

@Acrophost
Copy link

Doesn't persist after fixes on ck/11438-beforeinput-ime-research-vol1.1-android

@Mgsy Mgsy closed this as completed Sep 8, 2022
@Mgsy Mgsy added this to the iteration 57 milestone Sep 8, 2022
@Reinmar Reinmar modified the milestones: iteration 57, upcoming Sep 13, 2022
@Reinmar Reinmar modified the milestones: upcoming, iteration 58 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:android domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants