Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHS Research: Applying attributes to existing features - lists #10073

Closed
Mgsy opened this issue Jul 5, 2021 · 1 comment
Closed

GHS Research: Applying attributes to existing features - lists #10073

Mgsy opened this issue Jul 5, 2021 · 1 comment
Assignees
@jacekbogdanski
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 45 (v29...

Comments

@Mgsy
Copy link
Member

Mgsy commented Jul 5, 2021

Provide a description of the task

A research ticket for the main task - #9917.

Due to the complex model structure of the Lists feature, it's not possible to easily extend it with additional attributes. We will need to create separate integration for it.

For now, it's possible to extend li elements. ul and ol elements are removed during upcasting to the model. We could probably preserve them on e.g. the first list item of the list and restore them during downcast conversion.
@Mgsy Mgsy added type:task This issue reports a chore (non-production change) and other types of "todos". squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels Jul 5, 2021
@Mgsy Mgsy mentioned this issue Jul 5, 2021
Closed
@Mgsy Mgsy added this to the nice-to-have milestone Jul 6, 2021
@jacekbogdanski jacekbogdanski self-assigned this Jul 8, 2021
@jacekbogdanski jacekbogdanski modified the milestones: nice-to-have, iteration 45 Jul 16, 2021
@Reinmar
Copy link
Member

Reinmar commented Jul 22, 2021

Let's assume it's done :) We'll now work on a real implementation in #9917.

@Reinmar Reinmar closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 45 (v29.1.0)
Development

No branches or pull requests
3 participants
@Reinmar @jacekbogdanski @Mgsy