Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backspace/Delete keys integration should be switched to delete event #4587

Closed
szymonkups opened this issue Dec 22, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-widget#30
Closed

Backspace/Delete keys integration should be switched to delete event #4587

szymonkups opened this issue Dec 22, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-widget#30
Assignees
@szymonkups
Labels
package:widget type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@szymonkups
Copy link
Contributor

Currently we are handling backspace/delete key events in widget plugin: when selection is directly after the widget, backspace key selects entire widget (similar with delete key and selection just before widget).

Instead of listening to key events we should use delete event from DeleteObserver (which is handling key events internally). This is because delete event can be triggered by other input events than key press (IME for example).
@szymonkups szymonkups self-assigned this Dec 22, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-widget Dec 22, 2017
@Reinmar
Merge pull request #30 from ckeditor/t/29
ee6cc95 
Other: Switched to handling deletion around widgets by using the `delete` event instead of listening directly on key events. Closes #29.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-widget Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:widget labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:widget type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Using delete event with widgets instead of key handling ckeditor/ckeditor5-widget
2 participants
@szymonkups @mlewand