This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Introduce Watchdog #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jun 21, 2019
|
You can also add more tests for objects used as a context, check if they are properly connected with the editor. |
Co-Authored-By: Szymon Cofalik <[email protected]>
scofalik
reviewed
Jul 1, 2019
Co-Authored-By: Szymon Cofalik <[email protected]>
This was referenced Jul 1, 2019
pjasiun
pushed a commit
to ckeditor/ckeditor5-ckfinder
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-core
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-editor-balloon
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-editor-classic
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-editor-inline
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-editor-decoupled
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-engine
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-mention
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-ui
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-upload
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
pjasiun
pushed a commit
to ckeditor/ckeditor5-widget
that referenced
this pull request
Jul 2, 2019
Internal: Add context to CKEditorError exceptions. Required by ckeditor/ckeditor5-watchdog#2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ckeditor/ckeditor5#4692.
Requires:
CKEditorError, changeisCKEditorError()tois(), introduce theareConnectedThroughProperties()util ckeditor5-utils#289config.initialDataoption inClassicTestEditorandVirtualTestEditor. ckeditor5-core#181