Implement KeystrokeHandler#unset

[ma2ciek]

There's no option for now to unset the listener from the KeystrokeHandler despite the destroy() method. This method would be useful when there's a need to destroy some plugin during the edition.

---

If you'd like to see this feature implemented, add 👍 to this post.

[Reinmar]

This would not be a safe solution. Imagine that in every plugin you'd need to remember to unset keystrokes on Plugin#destroy().

There's been that second topic consisting of https://github.com/ckeditor/ckeditor5-core/issues/20 and #340 in which it was proposed to use events instead of set/remove() approach. I don't fully recall now, but I later came to the same conclusions during some other task.

So, that would also be a solution to this problem. You'd use the keystroke handler like this in your plugin:

this.listenTo( this.editor.keystrokes, 'Alt+Enter', () => ... )

However, I don't see yet what would be the responsibility of the KeystrokeHandler in this yet. It seems that it'd become a class which:

• can be plugged to listen to some key events (we use it now to listen on the editable or other parts of the UI – so we use multiple keystroke handlers),
• translates key codes to human-readable events (like Alt+Enter),
• provides useful API to handle the key press (but I don't think there's any specific need here).

Not sure, though, if going into events won't make it less useful.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).