Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileDialogButtonView is not properly bound with UploadCommand #2832

Closed
oskarwrobel opened this issue Dec 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#78
Closed

FileDialogButtonView is not properly bound with UploadCommand #2832

oskarwrobel opened this issue Dec 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#78
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@oskarwrobel
Copy link
Contributor

See:
https://github.com/ckeditor/ckeditor5-upload/blob/0fe248ad55c64f4a042949464d938f7f1aa98a2e/src/imageuploadbutton.js#L53

FileDialogButtonView is not a ButtonView instance but only a wrapper for ButtonView and input[file]. Should be:

view.buttonView.bind( 'isEnabled' ).to( command );
@oskarwrobel oskarwrobel self-assigned this Jan 8, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-upload Jan 8, 2018
Merge pull request #78 from ckeditor/t/77
d231ea6 
Fix: Fixed incorrect `ImageUploadButton` and `ImageUploadCommand` binding. Closes #77. Closes https://github.com/ckeditor/ckeditor5-ui/issues/357.
@oskarwrobel oskarwrobel removed their assignment Feb 23, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:upload labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Fix: Fixed incorrect ImageUploadButton and ImageUploadCommand binding. ckeditor/ckeditor5-upload
2 participants
@oskarwrobel @mlewand