-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure z-indexes #5415
Comments
I think "Solution 2" in #5352 is the right thing to do. |
Solution 2 is not a solution to this issue (I mean – not directly). Here we should make sure that different UI elements have different z-indexes. So "Solution 2" must be applied together with a rule that different classes are used. |
Yes, that's what I meant. |
Is it done or will be done in this iteration? If not, please move it to it15. |
WDYT @dkonopka? What impact would this have on Letters? |
I'm not so sure because in Letters I've never met similar problem related to same :root {
--ltrs-z-under: -1;
--ltrs-z-default: 1;
--ltrs-z-float: 99;
--ltrs-z-air: 999;
--ltrs-z-cover: 9999;
--ltrs-z-overall: 9999999;
} @define-mixin generate-z-classes $prefix {
.$prefix {
z-index: var(--$prefix);
}
} IMHO we can manage z-indexes in ckeditor5 with more than two current variables. :root {
--ck-z-default: 1;
--ck-z-modal: 999;
} Or we can use variables based on UI element :root {
--ck-z-sticky-panel: 999;
--ck-z-balloon-panel: calc( var(--ck-z-sticky-panel) + 1)
} but it's just an idea. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
Right now sticky panel has z-index:999 and the ctx balloon has also 999. I think that they are correctly displayed (ctx balloon over sticky panel) because they are in the right order in the DOM.
IMO, z-indexes should differ here.
The text was updated successfully, but these errors were encountered: