Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IME][Chrome][Safari] Composing on the end of the link breaks composition #3118

Open
f1ames opened this issue May 30, 2018 · 4 comments
Open
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@f1ames
Copy link
Contributor

f1ames commented May 30, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

CKEditor 5 (v10.0.1)

📋 Steps to reproduce case 1

  1. Go to https://ckeditor5.github.io.
  2. Place selection on the end of any link.
  3. Switch to Spanish keyboard.
  4. Press Spanish accent character '.
  5. Press a.

✅ Expected result

Accented character is properly inserted (and is part of a link).

❎ Actual result

Accented character is not inserted. Instead a is inserted.

Chrome:
mar-29-2017 19-30-44

Safari:
feb-27-2018 11-46-19-safari

📋 Steps to reproduce case 2

Extracted from #3088 (see https://github.com/ckeditor/ckeditor5-typing/issues/95#issuecomment-393084080).

  1. Go to https://ckeditor5.github.io.
  2. Place selection on the end of any link.
  3. Switch to Japanese Hiragana keyboard.
  4. Press a few times.
  5. Navigate with up/down arrow keys through IME panel.

✅ Expected result

It is possible to navigate through IME panel without any effect on editors' content.

❎ Actual result

Chrome: Each time you navigate through IME panel new characters are inserted.
Safari: IME panel is not opened at all so it is not possible to compose anything.

Chrome:
mar-29-2017 19-25-56

📃 Other details that might be useful

Happens only in Safari (11.0.3 (13604.5.6)) and Chrome (66.0.3359.181 (Official Build) (64-bit)), Firefox works fine.

Extracted from #3088 (see https://github.com/ckeditor/ckeditor5-typing/issues/95#issuecomment-393084080). I believe the cause is same or very similar in those two cases which was the main reason I put them as a one issue.
I think it might be fixed with the first inline fillers improvement - https://github.com/ckeditor/ckeditor5-engine/issues/1342).

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@Reinmar Reinmar modified the milestones: backlog, next Nov 6, 2019
@Reinmar Reinmar added the support:2 An issue reported by a commercially licensed client. label Nov 6, 2019
@lslowikowska lslowikowska added support:1 An issue reported by a commercially licensed client. and removed support:2 An issue reported by a commercially licensed client. labels Nov 6, 2019
@Reinmar Reinmar added the domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). label Nov 18, 2019
@cai123nb
Copy link

cai123nb commented Jun 5, 2020

Any progress?

@Mgsy
Copy link
Member

Mgsy commented Jun 24, 2020

Another case:

Steps to reproduce

  1. Turn on Chinese (Pinyin - simplified).
  2. At the end of the link type "shisshishhi".

Current result

Can't convert the text.

@lslowikowska lslowikowska added support:2 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Jul 15, 2020
@Reinmar Reinmar removed the squad:red label Nov 2, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@LukaszGudel
Copy link
Contributor

Current state of this issue:

  • Case 1: Same result.
  • Case 2:
    • Firefox: works correctly.
    • Chrome: is not opening suggestions window and can not convert the text.
    • Safari: there is an issue with duplicating typed characters. Typing abcdef results in a ab abc abcd abcde abcdef

@Reinmar Reinmar added domain:dx This issue reports a developer experience problem or possible improvement. squad:core Issue to be handled by the Core team. and removed squad:dx labels Sep 9, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@aletorrado
Copy link

Hi, this is still broken in v35. Is there any plan to address this issue? Is any diagnosis made so far at least? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). package:typing squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

10 participants