Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounded corners should work for dropdown panel children in all panel positions #5806

Closed
oleq opened this issue Nov 26, 2019 · 1 comment · May be fixed by ckeditor/ckeditor5-theme-lark#254
Closed

Rounded corners should work for dropdown panel children in all panel positions #5806

oleq opened this issue Nov 26, 2019 · 1 comment · May be fixed by ckeditor/ckeditor5-theme-lark#254
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 70 (v41...

Comments

@oleq
Copy link
Member

oleq commented Nov 26, 2019

📝 Provide detailed reproduction steps (if any)

  1. Open a manual test or docs
  2. Set --ck-border-radius: 7px (or even bigger) using the inspector
  3. Observe corners of dropdown panels and their children in different panel positions (change _se, _sw, etc. panel suffixes to play around).

✔️ Expected result

In all the cases, things look good, the roundness is respected.

❌ Actual result

It's not so good ATM

Screenshot 2019-11-26 at 09 49 37

Screenshot 2019-11-26 at 09 51 18

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:theme-lark labels Nov 26, 2019
@oleq oleq mentioned this issue Nov 26, 2019
Open
@mlewand mlewand added this to the backlog milestone Dec 3, 2019
@mlewand mlewand added the domain:ui/ux This issue reports a problem related to UI or UX. label Dec 3, 2019
@Mgsy Mgsy modified the milestones: backlog, iteration 29 Dec 10, 2019
@Reinmar Reinmar modified the milestones: iteration 29, backlog Dec 16, 2019
@oleq oleq added the intro Good first ticket. label Mar 20, 2020
@oleq oleq modified the milestones: backlog, iteration 31 Apr 9, 2020
@oleq oleq modified the milestones: iteration 31, iteration 32 Apr 21, 2020
@Reinmar Reinmar modified the milestones: iteration 32, backlog Apr 30, 2020
@Reinmar Reinmar removed the intro Good first ticket. label Apr 30, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@pomek pomek closed this as completed in aae1fd1 Dec 12, 2023
@CKEditorBot CKEditorBot added this to the iteration 70 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 70 (v41.0.0)
6 participants
@Reinmar @oleq @pomek @mlewand @Mgsy @CKEditorBot