Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow typing after link #4763

Closed
Reinmar opened this issue Nov 28, 2016 · 8 comments · Fixed by ckeditor/ckeditor5-link#175 or ckeditor/ckeditor5-link#172
Closed

Allow typing after link #4763

Reinmar opened this issue Nov 28, 2016 · 8 comments · Fixed by ckeditor/ckeditor5-link#175 or ckeditor/ckeditor5-link#172
Labels
package:link type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 28, 2016

This was mentioned in https://github.com/ckeditor/ckeditor5-link/issues/11 but requires a separate ticket. We need to allow typing (non-linked text) right after a link.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 30, 2016

@vladikoff
Copy link

@cedrecium we need to keep an eye on this issue. It seems like a major blocker for the links feature.

links

@cedricium
Copy link

@vladikoff didn't see your comment until now due to your typo in my handle, but I definitely agree. This was one of the biggest issues we experienced in Quill; we would need to get this solved.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 14, 2017

@oleq, can you post a screencast of your hackathon's PoC? It's a solution that we can quickly turn into production-ready implementation, so it's worth knowing whether it's satisfying. It's not perfect, it's not 100% complete, but it's a quick (and still nice) win (IMO :P).

@oleq
Copy link
Member

oleq commented Dec 18, 2017

There you go:
typing-after-link-v4

@Reinmar
Copy link
Member Author

Reinmar commented Feb 9, 2018

This feature will be implemented in https://github.com/ckeditor/ckeditor5-engine/issues/1289.

@Reinmar Reinmar assigned oskarwrobel and unassigned szymonkups Feb 16, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-link Feb 27, 2018
Feature: Added two-step caret movement for links. See #72.
@Reinmar
Copy link
Member Author

Reinmar commented Feb 27, 2018

Not yet closed by ckeditor/ckeditor5-link#172. We added the caret mechanics but we miss either the highlighting or at least https://github.com/ckeditor/ckeditor5-link/issues/173.

@oleq
Copy link
Member

oleq commented Feb 27, 2018

@oskarwrobel oskarwrobel removed their assignment Feb 28, 2018
scofalik referenced this issue in ckeditor/ckeditor5-link Mar 7, 2018
Feature: Link will be now highlighted when selection is inside it. Closes #72.
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Mar 7, 2018
Feature: Added styles for a selected link element (see ckeditor/ckeditor5-link#72).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
7 participants