Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not execute on Edge (using BrowserStack) #4815

Closed
pomek opened this issue Oct 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-link#161
Closed

Tests do not execute on Edge (using BrowserStack) #4815

pomek opened this issue Oct 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-link#161
Assignees
Labels
package:link type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2017

The main issue: #615

In order to reproduce these issues, please follow this instruction – #615 (comment)How to run it on my local machine?

@pomek
Copy link
Member Author

pomek commented Nov 8, 2017

This test blocks everything:

should add #formView to the #_balloon and attach the #_balloon to the link element when collapsed selection is inside that link 

When I disabled it, two other tests fail:

  • Edge 16.16299.0 (Windows 10 0.0.0) LinkFormView constructor() should create child views FAILED
  • Edge 16.16299.0 (Windows 10 0.0.0) UnlinkCommand execute() non-collapsed selection should remove linkHref attribute from selected text and do not modified other attributes FAILED

Edge 16.16299.0 (Windows 10 0.0.0): Executed 129 of 130 (2 FAILED) (skipped 1) (2.541 secs / 0.728 secs)

@pomek
Copy link
Member Author

pomek commented Nov 8, 2017

UnlinkCommand fails because ending of selection is inside a $text element:

expected
'<$text bold="true" linkHref="url">f</$text>[<$text bold="true">ooba]<$text linkHref="url">r</$text></$text>'
to equal
'<$text bold="true" linkHref="url">f</$text>[<$text bold="true">ooba</$text>]<$text bold="true" linkHref="url">r</$text>'

@pomek
Copy link
Member Author

pomek commented Nov 8, 2017

Edge 16.16299.0 (Windows 10 0.0.0) LinkFormView constructor() should create child views failed because of my internal changes. I reverted it and this test passed.

@pomek pomek self-assigned this Nov 15, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-link Dec 5, 2017
Tests: Fixed failed tests on Edge . Closes #158.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants