-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The active font color is only selected in the document colors #2299
Comments
@Reinmar It was decided to have only one checkbox: |
Are there any arguments for not selecting both items? |
It was actually my suggestion to implement it with a single checkmark. The reason is that we have a relatively heavy way to indicate selected color and having both of these looked heavy/messy. @msamsel can you check out to a version before this change and provide a screen of a entire editor with a dropdown where both colors are selected? And next to it put a current screen (with only one selected) so we can compare it. |
I'm for the later. |
Fix: `ColorGrid` should set the `#isOn` property value of new `ColorTiles`. See ckeditor/ckeditor5-font#51.
Other: The active color should be marked both in the document colors and all colors. Closes #51.
This seems wrong to me. Because you will never see the checkmark in the normal grid. It will always be in the document colors.
The text was updated successfully, but these errors were encountered: