Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema helpers #4080

Closed
Reinmar opened this issue Jun 16, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#970
Closed

Add schema helpers #4080

Reinmar opened this issue Jun 16, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#970
Assignees
@Reinmar
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 16, 2017

See https://github.com/ckeditor/ckeditor5-core/issues/14.

In ckeditor5-core we implemented two helpers which were originally used by the ToggleAttributeCommand but which make perfect sense in the engine, as schema/selection utils.
@Reinmar Reinmar self-assigned this Jun 16, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-engine Jun 19, 2017
@szymonkups
Merge pull request #970 from ckeditor/t/969
34a7a06 
### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))

Feature: Introduced two `Schema` helpers – `#checkAttributeInSelection()` and `#getValidRanges()`. Closes #969.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

T/969: Added schema helpers ckeditor/ckeditor5-engine
2 participants
@Reinmar @mlewand