Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeDelta: empty AttributeDeltas should not be added to batch #4019

Closed
scofalik opened this issue Mar 17, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#876
Closed

AttributeDelta: empty AttributeDeltas should not be added to batch #4019

scofalik opened this issue Mar 17, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#876
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@scofalik
Copy link
Contributor

batch.setAttribute() and batch.removeAttribute() checks passed range/element and applies changes only where they are needed. However if element already has given value for given attribute, then no operation is applied and empty AttributeDelta instance is added to the batch (same when all items in a range have that value for that attribute).
@scofalik scofalik self-assigned this Mar 17, 2017
scofalik referenced this issue in ckeditor/ckeditor5-engine Mar 17, 2017
@scofalik
Changed: empty AttributeDeltas should not be added to batch. Fixes #875.
c907b5c
scofalik referenced this issue in ckeditor/ckeditor5-engine Mar 17, 2017
@scofalik
Changed: empty AttributeDeltas should not be added to batch. Fixes #875.
40d90a4
Reinmar referenced this issue in ckeditor/ckeditor5-engine Mar 17, 2017
@Reinmar
Merge pull request #876 from ckeditor/t/875
425399b 
Fix: Empty `AttributeDelta` should not be added to batch. Closes #875.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

Changed: empty AttributeDeltas should not be added to batch. Fixes #875. ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand