-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check RTL support #3788
Comments
A good way to test it is comparing the behavior we have in our implementation with the one in the native contenteditable. |
OK, it works as expected if the editable has |
Remember that we must, additionally, checked "mixed direction" in the content, like an Arabic word or phrase inside English content. Such content may appear within a |
I created a manual test in which you can compare, and eventually debug, RTL support issues. The most important thing I understood is that if you have a mixed content (RTL text next to LTR or RTL text in LTR container), then really weird things happen. Fortunately, it's exactly the same behaviour which you get in native So, I consider this done and everything is working fine (tested in Chrome and Firefox). Tests were added in ckeditor/ckeditor5-typing@64ad8c1 |
I tested mixed content without those spans. I don't think that something could be wrong with spans, because it's browser who renders that mess and moves the selection. In the DOM everything is in the right order – range end is always after range start in DOM order. E.g. this works nice, even though visually the range is discontiguous: |
Hello, |
We should check how engine and existing features work with RTL content.
The text was updated successfully, but these errors were encountered: