Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model utils: setData should load data and set selection in the editor in such a way that they are rendered #3738

Closed
Reinmar opened this issue Jun 1, 2016 · 3 comments · Fixed by ckeditor/ckeditor5-engine#533
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 1, 2016

Related to https://github.com/ckeditor/ckeditor5-engine/issues/441.

Currently setData() just inserts the data into the model, but not in a way that would trigger rendering the content. It should use a similar method as here in the tests: https://github.com/ckeditor/ckeditor5-engine/blob/1a79448aa15cd1692cc02a1589ed945fc9823cf5/tests/editingcontroller.js#L139-L149

@Reinmar
Copy link
Member Author

Reinmar commented Jun 1, 2016

This issue is very important, because every single feature which introduces some converters will want to use this method.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 1, 2016

As a workaround I'm planning to use the data pipeline. That's not going to allow me to set the selection and analysing the code will be harder because you will load data which will be transformed to model and then to view. But other than that, this method will be enough.

@Reinmar
Copy link
Member Author

Reinmar commented Jul 7, 2016

This method should work like the DataController.set() method.

@szymonkups szymonkups self-assigned this Jul 14, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 2 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants