Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema#removeDisallowedAttributes does not check all children of given element #4535

Closed
oskarwrobel opened this issue Sep 4, 2019 · 1 comment
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oskarwrobel
Copy link
Contributor

When an element with children is passed to the Schema#removeDisallowedAttributes it may happen that some elements won't be cleared.

<parent>
  <$text foo="a">a</$text><$text foo="b">b</$text><$text foo="c">c</$text>
</parent>

When all attributes are disallowed in text for the parent element, then the last one won't be cleared.

<parent>
  ab<$text foo="c">c</$text>
</parent>

While removing attributes nodes are merged and this affects iterator.

@oskarwrobel oskarwrobel self-assigned this Sep 4, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-engine Sep 13, 2019
Fix: Improved filtering out disallowed attributes on child elements. #1789.
@Reinmar
Copy link
Member

Reinmar commented Oct 3, 2019

Closed with ckeditor/ckeditor5-engine#1790.

@Reinmar Reinmar closed this as completed Oct 3, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants