Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-render markers for which view element has been unbound during conversion #4532

Closed
scofalik opened this issue Aug 13, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1781
Closed

Re-render markers for which view element has been unbound during conversion #4532

scofalik opened this issue Aug 13, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1781
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@scofalik
Copy link
Contributor

There is a buggy scenario connected with markers, mapper and renaming elements:

  1. Create a marker and map it to a view container element (for example table cell).
  2. Rename that view container element (for example, set/unset table header).

Since the marker range has not changed, it won't be converted. But the renaming will remove the old view container element and insert a new one. This will lead to a situation when view marker representation is lost.
@scofalik scofalik self-assigned this Aug 13, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine Aug 16, 2019
Merge pull request #1781 from ckeditor/t/1780
5661fb6 
Other: Introduced automatic marker re-rendering during conversion for markers which view element was unbound. Closes #1780.

BREAKING CHANGE: New parameter introduced in `DowncastDispatcher#convertChanges()`. Now it is `convertChanges( differ, markers, writer )`.
BREAKING CHANGE: Although it was rather impossible to use `DowncastDispatcher` without specifying any conversion API in the constructor, now it is a required parameter.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
2 participants
@scofalik @mlewand