Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let for unbiding single elements from marker name in Mapper #4523

Closed
scofalik opened this issue Jul 9, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1759
Closed

Let for unbiding single elements from marker name in Mapper #4523

scofalik opened this issue Jul 9, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1759
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 26

Comments

@scofalik
Copy link
Contributor

scofalik commented Jul 9, 2019

At the moment, we have Mapper#unbindElementsFromMarkerName() which unbinds all elements from given element name. This was the only case that we had, so it was easier just to unbind all elements than fire it for every item in a loop.

However, unbinding for a single item is more flexible and we need it for proper handling of more complex, custom marker converters.
@scofalik scofalik self-assigned this Jul 9, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jul 12, 2019
Merge pull request #1759 from ckeditor/t/1758
52e701d 
Other: Allowed for unbinding single elements from a marker name in `Mapper`. Closes #1758.

BREAKING CHANGE: `Mapper#unbindElementsFromMarkerName( markerName )` was replaced by `Mapper#unbindElementFromMarkerName( element, markerName )`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Allow for unbinding single elements from a marker name in Mapper ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand