You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When working on UpcastWriter we made it as much consistent as possible with DowncastWriter. However, DowncastWriter has some inconsistencies itself which could be fixed:
remove() is inconsistent only because downcastWriter takes a range only. TBH, I'd change downcastWriter to accept both range and element and simply check if element is passed, if so, create a range on it (Range.createOn()). When this is done, the methods are consistent enough to get a thumbs up from me.
rename() is available in DowncastWriter and has wrong order. I'd change the order there.
The text was updated successfully, but these errors were encountered:
The only thing which makes me sad about this change is that after it the DowncastWriter.rename() method signature will be inconsistent with the model/writer.rename() method signature. However, since those writers does not have so much in common as Upcast and Downcast writers I think it is acceptable.
Still it may bring some confusion for developers who use both model and view writers frequently.
Other: Swapped parameters order in the `DowncastWriter#rename()` method. The `DowncastWriter#remove()` method now accepts range or item. Closes #1521.
BREAKING CHANGE: Swapped parameters order in the `DowncastWriter` (former `engine\view\writer`) `rename()` method. See #1521.
mlewand
transferred this issue from ckeditor/ckeditor5-engine
Oct 9, 2019
Extracted from ckeditor/ckeditor5-engine#1503.
When working on
UpcastWriter
we made it as much consistent as possible withDowncastWriter
. However,DowncastWriter
has some inconsistencies itself which could be fixed:The text was updated successfully, but these errors were encountered: