Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to automate selection attribute converstion #4243

Closed
pjasiun opened this issue Jan 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1247
Closed

Try to automate selection attribute converstion #4243

pjasiun opened this issue Jan 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1247
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@pjasiun
Copy link

pjasiun commented Jan 15, 2018

Right now when you define an attribute to element converter you need to define also selection attribute converter. It is something you need to remember about and it is not very intuitive.

https://github.com/ckeditor/ckeditor5-engine/blob/47291ebfee56cb20a110f6c38407476159dfbd69/src/conversion/buildmodelconverter.js#L259-L260

Since these converters are very similar, we should try to merge them to handle everything using a single event.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jan 19, 2018
Merge pull request #1247 from ckeditor/t/1238
9a53251 
Other: Simplified model to view selection conversion. Closes #1238.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Simplified conversion by dropping selectionAttribute event. ckeditor/ckeditor5-engine
3 participants
@pjasiun @scofalik @mlewand