From 18bdbd70e287f6206a287b9ff1900eb21a7decce Mon Sep 17 00:00:00 2001 From: Marek Lewandowski Date: Thu, 8 Aug 2019 11:47:13 +0200 Subject: [PATCH 1/3] Docs: Removed nonexisting `consumable` parameter in DowncastDispatcher#selection event. --- src/conversion/downcastdispatcher.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conversion/downcastdispatcher.js b/src/conversion/downcastdispatcher.js index c0c11f3c8..1a9e90c22 100644 --- a/src/conversion/downcastdispatcher.js +++ b/src/conversion/downcastdispatcher.js @@ -542,7 +542,6 @@ export default class DowncastDispatcher { * * @event selection * @param {module:engine/model/selection~Selection} selection Selection that is converted. - * @param {module:engine/conversion/modelconsumable~ModelConsumable} consumable Values to consume. * @param {module:engine/conversion/downcastdispatcher~DowncastConversionApi} conversionApi Conversion interface * to be used by callback, passed in `DowncastDispatcher` constructor. */ From 8cda2e90c51e55f07489639180455cfbbd856d64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Fri, 9 Aug 2019 10:48:57 +0200 Subject: [PATCH 2/3] Remove non-existing consumable parameter from DowncastDispatcher events docs. --- src/conversion/downcastdispatcher.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/conversion/downcastdispatcher.js b/src/conversion/downcastdispatcher.js index 1a9e90c22..a65582566 100644 --- a/src/conversion/downcastdispatcher.js +++ b/src/conversion/downcastdispatcher.js @@ -532,7 +532,6 @@ export default class DowncastDispatcher { * @param {String} data.attributeKey Attribute key. * @param {*} data.attributeOldValue Attribute value before the change. This is `null` when selection attribute is converted. * @param {*} data.attributeNewValue New attribute value. - * @param {module:engine/conversion/modelconsumable~ModelConsumable} consumable Values to consume. * @param {module:engine/conversion/downcastdispatcher~DowncastConversionApi} conversionApi Conversion interface * to be used by callback, passed in `DowncastDispatcher` constructor. */ @@ -577,7 +576,6 @@ export default class DowncastDispatcher { * the marker range was not collapsed. * @param {module:engine/model/range~Range} data.markerRange Marker range. * @param {String} data.markerName Marker name. - * @param {module:engine/conversion/modelconsumable~ModelConsumable} consumable Values to consume. * @param {module:engine/conversion/downcastdispatcher~DowncastConversionApi} conversionApi Conversion interface * to be used by callback, passed in `DowncastDispatcher` constructor. */ From 68d72bdaaf53bf0fc278a8905004ab6501d223fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Fri, 9 Aug 2019 10:54:52 +0200 Subject: [PATCH 3/3] Update addMarker event docs. --- src/conversion/downcastdispatcher.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conversion/downcastdispatcher.js b/src/conversion/downcastdispatcher.js index a65582566..ae2f63b52 100644 --- a/src/conversion/downcastdispatcher.js +++ b/src/conversion/downcastdispatcher.js @@ -556,17 +556,17 @@ export default class DowncastDispatcher { * If the marker range is not collapsed: * * * the event is fired for each item in the marker range one by one, - * * consumables object includes each item of the marker range and the consumable value is same as event name. + * * `conversionApi.consumable` includes each item of the marker range and the consumable value is same as event name. * * If the marker range is collapsed: * * * there is only one event, - * * consumables object includes marker range with event name. + * * `conversionApi.consumable` includes marker range with event name. * * If selection inside a marker is converted: * * * there is only one event, - * * consumables object includes selection instance with event name. + * * `conversionApi.consumable` includes selection instance with event name. * * @event addMarker * @param {Object} data Additional information about the change.