Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On destroy, element's innerHTML should be replaced with data #2263

Closed
Reinmar opened this issue Jun 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-editor-inline#20
Closed

On destroy, element's innerHTML should be replaced with data #2263

Reinmar opened this issue Jun 13, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-editor-inline#20
Assignees
@oleq
Labels
package:editor-inline type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 13, 2017

Since on editor init the content of the original element is upcasted to the output of the editing pipeline, on destroy this should be reverted.
@Reinmar
Copy link
Member Author

Reinmar commented Jun 13, 2017

The issue comes from the fact that on destroy() this editor tries to use updateEditorElement() but it makes no sense to call it at that moment because the engine is still up and it reverts all the changes immediately.

oleq referenced this issue in ckeditor/ckeditor5-editor-inline Jun 14, 2017
@oleq
Fix: Editor element should be filled up with data upon destroy. Close…
5a998c3 
…s #19.
Reinmar referenced this issue in ckeditor/ckeditor5-editor-inline Jun 20, 2017
@Reinmar
Merge pull request #20 from ckeditor/t/19
fe7d27b 
Fix: Editor element should be filled up with data once the editor is destroyed. Closes #19.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-editor-inline Oct 8, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:editor-inline labels Oct 8, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 8, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:editor-inline type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/19: Editor element should be filled up with data upon destroy ckeditor/ckeditor5-editor-inline
3 participants
@Reinmar @oleq @mlewand