Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The options.onInit funciton doesn't get the CKFinder instance #2642

Closed
jodator opened this issue Aug 8, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ckfinder#46
Closed

The options.onInit funciton doesn't get the CKFinder instance #2642

jodator opened this issue Aug 8, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ckfinder#46
Assignees
@jodator
Labels
package:ckfinder type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@jodator
Copy link
Contributor

jodator commented Aug 8, 2019

The ckfinder.options.onInit allows to add custom behavior to the CKFinder. In order to do that it must have the finder instance passed to it:

https://github.com/ckeditor/ckeditor5-ckfinder/blob/1be8150b59fe281669cd8b6a73b4bc48ca691fe7/src/ckfindercommand.js#L76

Right now it doesn't.
@jodator jodator self-assigned this Aug 8, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-ckfinder Aug 8, 2019
@Reinmar
Merge pull request #46 from ckeditor/t/45
e53558c 
Fix: Pass CKFinder instance to a user-defined onInit() function. Closes #45.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ckfinder Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ckfinder labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:ckfinder type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Pass CKFinder instance to a user-defined onInit() function. ckeditor/ckeditor5-ckfinder
2 participants
@jodator @mlewand