From 765c01150e495fda4b9d1734b0ac49b253bf755c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Wed, 16 Jan 2019 16:30:08 +0100 Subject: [PATCH 1/2] Add memory leak test. --- tests/ckeditor.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/ckeditor.js b/tests/ckeditor.js index 720d2e3cf7..d434ef4751 100644 --- a/tests/ckeditor.js +++ b/tests/ckeditor.js @@ -7,6 +7,7 @@ import ClassicEditor from '../src/ckeditor'; import BaseClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor'; +import { describeMemoryUsage, testMemoryUsage } from '@ckeditor/ckeditor5-core/tests/_utils/memory'; describe( 'ClassicEditor build', () => { let editor, editorElement; @@ -23,7 +24,7 @@ describe( 'ClassicEditor build', () => { editor = null; } ); - describe( 'buid', () => { + describe( 'build', () => { it( 'contains plugins', () => { expect( ClassicEditor.builtinPlugins ).to.not.be.empty; } ); @@ -200,4 +201,10 @@ describe( 'ClassicEditor build', () => { } ); } ); } ); + + describeMemoryUsage( () => { + testMemoryUsage( + 'should not grow on multiple create/destroy', + () => ClassicEditor.create( document.querySelector( '#mem-editor' ) ) ); + } ); } ); From 55137b93a0abef008aaaca7830780be49419c5b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Tue, 22 Jan 2019 10:34:18 +0100 Subject: [PATCH 2/2] Add missing ckeditor5-core dependency. --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index f73b361367..74d319be11 100644 --- a/package.json +++ b/package.json @@ -30,6 +30,7 @@ "@ckeditor/ckeditor5-basic-styles": "^10.1.0", "@ckeditor/ckeditor5-block-quote": "^10.1.1", "@ckeditor/ckeditor5-ckfinder": "^10.0.0", + "@ckeditor/ckeditor5-core": "^11.1.0", "@ckeditor/ckeditor5-dev-utils": "^11.0.1", "@ckeditor/ckeditor5-dev-webpack-plugin": "^7.0.1", "@ckeditor/ckeditor5-easy-image": "^10.0.4",