InlineAutoformatEngine should work with commands, not attributes

[Reinmar]

We had to make it use attributes because of https://github.com/ckeditor/ckeditor5-undo/issues/44.

If we'll be able to resolve that issue, then we should also change the inline autoformatter so it works with commands (like the block one).

[Reinmar]

I'll fix this issue in order to remove the dependency from the ckeditor5-core (https://github.com/ckeditor/ckeditor5-core/issues/14#issuecomment-309447944).

[Reinmar]

I pushed t/7 with my WIP, but I need to give up for now.

There are a couple of problems:

• The test suite for this feature is rather small what makes me uncomfortable refactoring this code.
• While working on this I stumbled upon https://github.com/ckeditor/ckeditor5-engine/issues/654 which made me using some complicated construct in the code.
• The idea of using a command instead of raw operations is that we want to reuse the command's logic – this is both – execution and state querying. Unfortunately, there are two issues with the state querying here – https://github.com/ckeditor/ckeditor5-core/issues/92 and https://github.com/ckeditor/ckeditor5-core/issues/93.

[Reinmar]

The idea of using a command instead of raw operations is that we want to reuse the command's logic – this is both – execution and state querying. Unfortunately, there are two issues with the state querying here – ckeditor/ckeditor5-core#92 and ckeditor/ckeditor5-core#93.

PS. To make it clear – I think that the autoformat should abort doing any changes to the content if the command is disabled.

[Reinmar]

#1239 raises the priority of this ticket.

The minimum is that autoformat should properly check the schema before doing anything. As I commented in #1239 (comment) it checks it but only when applying the attribute. It should abort earlier and not make any changes.

[Reinmar]

A DUP https://github.com/ckeditor/ckeditor5-autoformat/issues/70 comes with a PR: ckeditor/ckeditor5-autoformat#71.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).