Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long image alt text protrudes into editor when image is selected #898

Closed
b2m opened this issue Sep 12, 2017 · 1 comment
Closed

Long image alt text protrudes into editor when image is selected #898

b2m opened this issue Sep 12, 2017 · 1 comment
Assignees
Labels
accessibility Issue related to accessibility. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@b2m
Copy link

b2m commented Sep 12, 2017

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

None found.

Provide detailed reproduction steps (if any)

There is a bug concerning long texts in the alt attribute of images in combination with the uploadimage plugin.

  1. open https://codepen.io/anon/pen/oGNbKQ?editors=1010
  2. select image by clicking on it

Expected result

Image should be selected, nothing more.

Actual result

The content of the alt attribute is copied to the hidden selection (ok).
But the text it is so long that the hidden selection it is no longer hidden but partly visible to the user (not ok).

Other details

  • Browser: Chrome, Firefox
  • OS: independent
  • CKEditor version: 4.7.2
  • Installed CKEditor plugins: image2, uploadimage
@mlewand mlewand added plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Sep 12, 2017
@mlewand mlewand added this to the Backlog milestone Sep 12, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Sep 12, 2017
@mlewand
Copy link
Contributor

mlewand commented Sep 12, 2017

Our trick did not expect that the alt will be as long as it is. 🙂 Generally you wan't to keep alt as short and meaningful as possible, but ofc this is a bug.

For the implementer/reviewer: it's crucial to ensure accessibility after the fix. Ensure that the screen reader reads labels for widgets. There should be a manual test for it somewhere as I recall we were working with not that long ago.

I guess the fix will be still trivial, we could simply hide it or set the width/height of this label.

@mlewand mlewand added accessibility Issue related to accessibility. target:minor Any docs related issue that can be merged into a master or major branch. labels Sep 12, 2017
@engineering-this engineering-this self-assigned this Aug 17, 2018
@Comandeer Comandeer modified the milestones: Backlog, 4.10.2 Sep 27, 2018
@mlewand mlewand modified the milestones: 4.10.2, 4.11.0 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants